Parquet: Simplify changes from #3723 #3773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@RussellSpitzer can you take a look at this follow-up to #3723? |
Contributor
Author
|
@SinghAsDev FYI |
Contributor
|
Thanks @rdblue , this makes sense. I like that we don't have to modify/ construct parquet types with this change. I have a couple more changes along this, and would like to get your reviews on them. Will likely post them today. |
SinghAsDev
reviewed
Dec 19, 2021
| @Override | ||
| public void beforeElementField(Type element) { | ||
| super.beforeElementField(makeElement(element)); | ||
| // normalize the name to "element" so that the mapping will match structures with alternative names |
Contributor
There was a problem hiding this comment.
@rdblue would it help if we add some example of this alternate naming source here? Same for the map's key and value fields.
Contributor
Author
There was a problem hiding this comment.
I don't think so. The main point is that we don't want to care what the other name was.
danielcweeks
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a couple of modifications to #3723 to make it more consistent and simpler.
fieldNames, move name handling intoApplyNameMappingmakeListType