Core: Fix check for new deleted files in manifests #3581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
commented
Nov 19, 2021
| } | ||
|
|
||
| @Test | ||
| public void testAlreadyDeletedFilesAreIgnoredDuringDeletesByRowFilter() { |
Contributor
Author
There was a problem hiding this comment.
This test was failing before and represents a scenario I am talking about.
aokolnychyi
commented
Nov 19, 2021
|
|
||
| // delete the second data file using a row filter | ||
| // the commit should succeed as there is only one live data file | ||
| table.newDelete() |
Contributor
Author
There was a problem hiding this comment.
This was failing as we were checking the already deleted file.
Contributor
Author
szehon-ho
approved these changes
Nov 19, 2021
rdblue
approved these changes
Nov 19, 2021
Contributor
|
Good find! |
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Dec 15, 2021
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic for checking whether manifests have new files to delete. Specifically, we should ignore files that were previously deleted.