Skip to content

Core: Use Immutables for TableMetadata #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nastra wants to merge 1 commit into from
Closed

Core: Use Immutables for TableMetadata #3580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions baseline.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ subprojects {
pluginManager.withPlugin('com.palantir.baseline-error-prone') {
tasks.withType(JavaCompile).configureEach {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests and generated src
'-XepExcludedPaths:.*/(test|generated-src)/.*',
// error-prone is slow, don't run on tests/generated-src/generated
Copy link
Contributor Author

@nastra nastra Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so that generated immutable classes aren't checked by errorprone

'-XepExcludedPaths:.*/(test|generated-src|generated)/.*',
// specific to Palantir
'-Xep:ConsistentLoggerName:OFF', // Uses name `log` but we use name `LOG`
'-Xep:FinalClass:OFF',
Expand Down
2 changes: 2 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ project(':iceberg-common') {

project(':iceberg-core') {
dependencies {
annotationProcessor "org.immutables:value"
api project(':iceberg-api')
implementation project(':iceberg-common')
implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
Expand All @@ -212,6 +213,7 @@ project(':iceberg-core') {
exclude group: 'org.tukaani' // xz compression is not supported
}

implementation "org.immutables:value"
implementation "com.fasterxml.jackson.core:jackson-databind"
implementation "com.fasterxml.jackson.core:jackson-core"
implementation "com.github.ben-manes.caffeine:caffeine"
Expand Down
Loading