Build: Enable checkstyle for all engine versions #3550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnightChess
reviewed
Nov 15, 2021
.github/workflows/java-ci.yml
Outdated
| with: | ||
| java-version: 8 | ||
| - run: ./gradlew build -x test -x javadoc -x integrationTest | ||
| - run: ./gradlew -DflinVersions=1.12,1.13 -DsparkVersions=2.4,3.0,3.1,3.2 -DhiveVersions=2,3 build -x test -x javadoc -x integrationTest |
Contributor
There was a problem hiding this comment.
Typo in "flinkVersions" ?
Member
Author
There was a problem hiding this comment.
Yes, I missed it. Thanks for the finding, @KnightChess !
rdblue
approved these changes
Nov 15, 2021
Contributor
|
Thanks for fixing this, @openinx! I'm glad we caught this and re-enabled checkstyle before we needed to fix code at the same time! |
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we've just enabled the checkstyles check for the default engines. As @rdblue suggested, it's better to enable checkstyles for all the engines.