Build - Ensure checkstyle runs for Flink for all PRs by removing -Pquick=true
#3519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to address this comment: #3501 (comment)
Many thanks to @openinx and @stevenzwu who noticed that the checkstyle wasn't running.
I recently had to fix something similar with Spark for the 0.12.1 release build, but I thought it was due to the version split up (and that somebody's PR get in without running tests for a rebase).
Removing
quick=truecauses checkstyle to run again. For CI, we should be running all checks (and can work to disable some if we don't need them).@openinx suggested in this PR: #3509 that we remove the path ignores in
java-ci.yaml. But I think that would negate the work of splitting up the tests and the speed built up that we have seen from that.If we find this takes too long (as it does run checkstyle fot transitive deps), then we can make one single check run but keep the Java CI and associated tests standalone still as another option.
In either case, this PR will flesh out any existing checks that aren't presently passing as things have not been running. So if we decide to go the route @openinx suggested, this PR (and others like it) will still find any existing checkstyle error issues and give us a chance to fix them.