Flink: fix flaky testTwoSinksInDisjointedDAG that may stuck #3514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tFlinkIcebergSink#testTwoSinksInDisjointedDAG. The purpose of this test method is that we can constrcut two Iceberg sinks in the same job/DAG with different UIDs. we don't need the custom source BoundedTestSource for this purpose.
Contributor
Author
kbendick
approved these changes
Nov 10, 2021
Contributor
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
Nice! This is a solid work around to the original problem.
In Flink 1.14 (I believe), we won't have the issue that sources can shut down before final checkpoint in a batch job anymore. IIRC that has been fixed.
But as you mentioned, we're not testing that. Just that we can have two Iceberg Flink sinks in one job.
Thanks @stevenzwu!
rdblue
approved these changes
Nov 14, 2021
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
apache#3514) The purpose of this test method is that we can construct two Iceberg sinks in the same job/DAG with different UIDs. The custom source BoundedTestSource is not needed for this purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch from BoundedTestSource to simple fromCollection for TestFlinkIcebergSink#testTwoSinksInDisjointedDAG. The purpose of this test method is that we can construct two Iceberg sinks in the same job/DAG with different UIDs. we don't need the custom source BoundedTestSource for this purpose.
fix #3112