Arrow: Update netty buffer version to 4.1.68.Final #3512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
changed the title
RussellSpitzer
approved these changes
Nov 9, 2021
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Do you think we need to run the benchmarks on this bump? Since it is internal and used by by a lot of codepaths, although not directly by us I think...
rdblue
approved these changes
Nov 9, 2021
Contributor
|
@RussellSpitzer, that seems like a good idea, but if this is the version that both Spark and Arrow use, I don't think that we have much choice but to go ahead with it. |
Member
|
SGTM, I forgot if we were shading our netty |
nastra
approved these changes
Nov 10, 2021
Contributor
Author
|
Thank you all for the review. |
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update netty buffer version to 4.1.68.Final since Arrow has been updated to 6.0 by #3446. Arrow 6.0 depends on netty buffer 4.1.68.Final. https://mvnrepository.com/artifact/org.apache.arrow/arrow-memory-netty/6.0.0.
Meanwhile, Spark 3.2 also depends on netty buffer 4.1.68.Final.
The only reason we set it to
4.1.63.Finalinstead of4.1.68.Finalin #3420 is that, Arrow was 5.0 at that time.cc @aokolnychyi @rdblue @kbendick @RussellSpitzer @karuppayya