Core: rename min-deletes-per-file in BinPackStrategy#3506
Merged
rdblue merged 1 commit intoapache:masterfrom Nov 9, 2021
jackye1995:rewrite-delete-threshold
Merged
Core: rename min-deletes-per-file in BinPackStrategy#3506rdblue merged 1 commit intoapache:masterfrom jackye1995:rewrite-delete-threshold
rdblue merged 1 commit intoapache:masterfrom
jackye1995:rewrite-delete-threshold
Conversation
rdblue
approved these changes
Nov 9, 2021
Contributor
|
I think the Flink failures are unrelated. I'll merge. |
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on conversation in #3454 (comment), use a different name for
min-deletes-per-fileto avoid confusion. Currently my idea is to usedelete-file-threshold. Any thoughts? @rdblue @RussellSpitzer