Skip to content

Checkstyle: remove use of Parquet Preconditions and Apache Commons IOUtils #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackye1995 merged 1 commit into from
Nov 5, 2021
Merged

Checkstyle: remove use of Parquet Preconditions and Apache Commons IOUtils #3472

jackye1995 merged 1 commit into from
Nov 5, 2021

Conversation

@jackye1995
Copy link
Contributor

@jackye1995 jackye1995 commented Nov 4, 2021 •
edited
Loading

Tested checkstyle works:

> Task :iceberg-spark:iceberg-spark-3.2:checkstyleMain
[ant:checkstyle] [ERROR] /projects/iceberg/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java:26:1: Use Preconditions from bundled-guava module instead. [GuavaClassesInParquet]

> Task :iceberg-aliyun:checkstyleTest FAILED
[ant:checkstyle] [ERROR] /projects/iceberg/aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalController.java:172: Prefer Guava's ByteStreams.copy to avoid charset/stream closing issues. [RegexpSinglelineJava]

@jackye1995 jackye1995 requested a review from kbendick November 4, 2021 22:42
@jackye1995 jackye1995 requested a review from nastra November 4, 2021 22:42
kbendick
kbendick approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @jackye1995!

nastra
nastra approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackye1995
Copy link
Contributor Author

jackye1995 commented Nov 5, 2021

Thanks for the review! @kbendick @nastra

@jackye1995 jackye1995 merged commit ce65722 into apache:master Nov 5, 2021
KnightChess pushed a commit to KnightChess/iceberg that referenced this pull request Nov 7, 2021
Checkstyle: remove use of Parquet Preconditions and Apache Commons IO…
196685e 
…Utils (apache#3472)
Initial-neko pushed a commit to Initial-neko/iceberg that referenced this pull request Nov 23, 2021
@miniFixer
Checkstyle: remove use of Parquet Preconditions and Apache Commons IO…
49bf197 
…Utils (apache#3472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nastra nastra nastra approved these changes

+1 more reviewer

@kbendick kbendick kbendick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ALIYUN arrow data INFRA parquet spark

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackye1995 @nastra @kbendick