Skip to content

Conversation

@samredai
Copy link
Contributor

@samredai samredai commented Nov 2, 2021

This PR adds a few more small tweaks to the docs site.

  • Remove top-level Engines section and pull out all of it's contents to the top level
  • Add logos for all of the engines and for the API and Project sections
  • Break up the single large hive.md file so that the nav is more consistent with the other engines
  • Add back the "How To Release" as a subsection under Project

Screen Shot 2021-11-02 at 9 34 37 AM

site/mkdocs.yml Outdated
- Flink:
- Getting Started: flink.md
- Flink Connector: flink-connector.md
- Hive:
Copy link
Contributor

@rdblue rdblue Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hive isn't that long of a page right now. Why split it out in this commit rather than just leaving it as-is and having a high-level link to the page? If we leave it as-is then we don't need to worry about permalinks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was really just to make the drop-downs look consistent but I'm realizing that issue partially goes away now that everything is flat. I'll consolidate the hive section back into a single file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! Hive is now a single top level item that points to hive.md and renders the whole page when you click on it.

Screen Shot 2021-11-03 at 7 38 43 AM

.

@rdblue rdblue merged commit d632d1f into apache:master Nov 3, 2021
@rdblue
Copy link
Contributor

rdblue commented Nov 3, 2021

Thanks, @samredai!

KnightChess pushed a commit to KnightChess/iceberg that referenced this pull request Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants