Hive: Fix Catalogs.hiveCatalog method for default catalogs

[pvary]

After #2565 the Catalogs.loadCatalog is synchronised with the CatalogUtil implementation.
Catalogs.hiveCatalog is not fixed, and also not tested.

This caused issues when I have tried to port this to the Hive repo.

The PR fixes the method, and also adds test.

[pvary]

CC: @jackye1995, @marton-bod

[kbendick]

Hi @pvary. On the mailing list, when you said:

This breaks Hive queries, if no catalog is set, but this still needs to be reviewed before merge.

Did you mean that this patch will break hive queries if not catalog is set after it's applied, or does it fix hive queries breaking if no catalog is set?

Thanks as always for your contributions 🙂

[pvary]

Did you mean that this patch will break hive queries if not catalog is set after it's applied, or does it fix hive queries breaking if no catalog is set?

@kbendick: My bad 😄
Ported #2565 to Hive, and the query tests started to break. In those tests we were not setting any catalogs, and the getCatalog returned a HiveCatalog but the Catalogs.hiveCatalog returned false. This is wrong, and also broke the tests, which started to fail when creating a table with Table location not set errors

[kbendick]

This looks good to me.

I checked it out locally, and some Flink checkstyle tests are failing, but that's certainly unrelated. I rebased locally off of master and the problems seem to go away. If you want to rebase and push, go ahead, but I don

[rdblue]

Looks good to me. Thanks, @pvary! Sorry it took me a while to get to this review.

[pvary]

Thanks @kbendick and @rdblue for the review and merge!