Reduce Excessive Build Logs - Fix ErrorProne AvoidNewHashMapInt which adds perf gains #3260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
changed the title
kbendick
changed the title
rdblue
reviewed
Oct 10, 2021
|
|
||
| } else { | ||
| Map<Integer, ByteBuffer> result = new HashMap<>(size); | ||
| Map<Integer, ByteBuffer> result = Maps.newHashMapWithExpectedSize(size); |
Contributor
There was a problem hiding this comment.
+1 This is one of the reasons why we prefer using factory methods in Maps.
rdblue
approved these changes
Oct 10, 2021
Contributor
|
Thanks, @kbendick! |
Contributor
Author
|
Adding this to the 0.12.1 release as it makes cherry-picking cleaner. |
kbendick
added a commit
to kbendick/iceberg
that referenced
this pull request
Oct 27, 2021
This should improve performance by allocating the correct size directly rather than reallocating later.
RussellSpitzer
pushed a commit
to RussellSpitzer/iceberg
that referenced
this pull request
Oct 29, 2021
This should improve performance by allocating the correct size directly rather than reallocating later.
kbendick
added a commit
to kbendick/iceberg
that referenced
this pull request
Oct 31, 2021
This should improve performance by allocating the correct size directly rather than reallocating later.
rdblue
pushed a commit
that referenced
this pull request
Nov 1, 2021
This should improve performance by allocating the correct size directly rather than reallocating later.
izchen
pushed a commit
to izchen/iceberg
that referenced
this pull request
Dec 7, 2021
This should improve performance by allocating the correct size directly rather than reallocating later.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Dec 13, 2021
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of ErrorProne warnings has gotten larger lately.
This fixes
AvoidNewHashMapIntas it has performance implications.Replaces all instance of
new HashMap(int)withnewHashMapWithExpectedSize, asnew HashMap(int)will initially allocate a map with 3/4th of the passed in size and then require growing / reallocating once it's actually filled with all of the values.