AWS: update DynamoDbCatalog.dropNamespace attr check #3035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to resolve an issue with
DynamoDbCatalog.dropNamespace()-- the dynamoDB delete fails as the conditionExpression evaluates to e.g.attribute_exists(my_db), rather thanattribute_exists(namespace).Example namespace record in dynamo:
{ "identifier": "NAMESPACE", "namespace": "my_db", "updated_at": 1628190933466, "created_at": 1628190933466, "v": "0203ec48-317b-4197-9712-4a7c91b5c91a", "p.owner": "bijan" }@jackye1995 - can you confirm this change makes sense / is what was intended?
@danielcweeks