Spec: Make contains_nan partition summary field optional in v2 #2864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minchowang
pushed a commit
to minchowang/iceberg
that referenced
this pull request
Aug 2, 2021
jun-he
pushed a commit
to jun-he/incubator-iceberg
that referenced
this pull request
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caught by the v2 discussion on the dev list. Because v1 manifests are valid in v2 and a manifest list is written for each snapshot, a writer may not know whether a v1 manifest contains a NaN value in one of its partitions. As a result, the
contains_nanfield of the manifest list's partition summary should not be required.