Fix bucketing of strings with non-BMP characters #2849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/bucket-bmp
branch
3 times, most recently
from
cd79cd9 to
73801c1
Compare
Member
Author
rdblue
reviewed
Jul 22, 2021
| "https://github.com/google/guava/issues/5648. Please resolve the TODO in BucketString.hash " + | ||
| "and remove this assertion", | ||
| hashBytes(asBytes), | ||
| MURMUR3.hashString(string, StandardCharsets.UTF_8).asInt()); |
Contributor
There was a problem hiding this comment.
Nit: Looks like indentation is off for this statement.
Member
Author
There was a problem hiding this comment.
eventually my IDE is not against me on this :)
fixed
rdblue
approved these changes
Jul 22, 2021
Contributor
|
Looks good to me. I agree with the choice to detect cases where |
Contributor
|
@findepi, looks like I don't have permission to update the indentation in the test. Could you fix that and I'll merge this? |
findepi
force-pushed
the
findepi/bucket-bmp
branch
from
73801c1 to
cb53800
Compare
rdblue
approved these changes
Jul 22, 2021
Member
Author
|
Thanks @rdblue |
Contributor
|
Thanks for fixing this, @findepi! Nice work. |
minchowang
pushed a commit
to minchowang/iceberg
that referenced
this pull request
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2837