Core: do not allow optional, double and float identifier fields #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
commented
Jun 16, 2021
| return identifierFieldIds() | ||
| .stream() | ||
| .map(id -> findField(id).name()) | ||
| .map(id -> lazyIdToName().get(id)) |
Contributor
Author
There was a problem hiding this comment.
this is another bug not really related to the discussion, trying to just merge it here instead of having another 1 line PR.
added 3 commits
June 16, 2021 14:38
Contributor
Author
|
restart flaky CI task |
rdblue
reviewed
Jun 17, 2021
| IllegalArgumentException.class, | ||
| "must not be nested in " + SCHEMA.findField("locations"), | ||
| () -> new SchemaUpdate(SCHEMA, SCHEMA_LAST_COLUMN_ID) | ||
| .setIdentifierFields("locations.value.lat") |
Contributor
There was a problem hiding this comment.
Was the test case using locations.value.lat removed?
Contributor
Author
There was a problem hiding this comment.
Yeah because that will hit the double check before hitting the map check. I added another one later with column new_map.value.val_col
rdblue
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rdblue follow up for #2654