Skip to content

Conversation

@TGooch44
Copy link
Contributor

Adds mypy ignores for pytz and dateutil

@TGooch44
Copy link
Contributor Author

TGooch44 commented Jun 16, 2021

@jun-he @rymurr I opened this PR to add some ignores on pytz and dateutil that are currently throwing linter errors on tox. Let me know if this looks ok, or if you'd prefer to handle it another way.

@rymurr
Copy link
Contributor

rymurr commented Jun 17, 2021

Hey @TGooch44 any reason to not add types-python-dateutil and types-pytz to the test env dependencies?

I believe mypy recently changed its default behaviour. Previously it silently auto-downloaded these packages.

@TGooch44
Copy link
Contributor Author

Sure, my thinking was that since these both have pretty limited usage, I didn't want to add in more deps, but I guess not really a big deal to add in type stubs.

Copy link
Contributor

@rymurr rymurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer deps over # noqa but im not so bothered.

@TGooch44 TGooch44 force-pushed the fix_mypy_import_issues branch from 2bab71a to e955b80 Compare June 17, 2021 16:39
@TGooch44
Copy link
Contributor Author

I personally prefer deps over # noqa but im not so bothered.

Given that these deps are only for mypy, I think you're right that it is better just to add them in over using ignores.

@TGooch44 TGooch44 merged commit 3c41289 into apache:master Jun 17, 2021
@TGooch44 TGooch44 deleted the fix_mypy_import_issues branch June 17, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants