Docs: Add commit.status-check on doc. #2661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I am not sure if the description of |
rdblue
reviewed
Jun 12, 2021
site/docs/configuration.md
Outdated
| | commit.retry.min-wait-ms | 100 | Minimum time in milliseconds to wait before retrying a commit | | ||
| | commit.retry.max-wait-ms | 60000 (1 min) | Maximum time in milliseconds to wait before retrying a commit | | ||
| | commit.retry.total-timeout-ms | 1800000 (30 min) | Maximum time in milliseconds to wait before retrying a commit | | ||
| | commit.status-check.num-retries | 3 | Number of times to check the commit status before failing | |
Contributor
There was a problem hiding this comment.
I think this is a bit too unclear because it isn't clear what "check the commit status" or "failing" mean exactly. I think this should be "Number of times to check whether a commit succeeded after a connection is lost before failing due to an unknown commit state".
Contributor
|
Merged. Thanks, @coolderli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configures to doc:
commit.status-check.num-retries,commit.status-check.min-wait-ms,commit.status-check.max-wait-ms,commit.status-check.total-timeout-ms.