Core: Support reading parquet bloom filter #2643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshmchenxi
force-pushed
the
bloom-filter-read
branch
from
ff3cccc to
4a59ee3
Compare
jshmchenxi
commented
May 27, 2021
Comment on lines
+246
to
+255
| switch (col.getPrimitiveType().getPrimitiveTypeName()) { | ||
| case BINARY: | ||
| return bloom.hash(Binary.fromString(value.toString())); | ||
| case INT32: | ||
| case INT64: | ||
| case FLOAT: | ||
| case DOUBLE: | ||
| return bloom.hash(value); | ||
| default: | ||
| throw new IllegalArgumentException("Cannot hash of type: " + col.getPrimitiveType().getPrimitiveTypeName()); |
Contributor
Author
There was a problem hiding this comment.
In case BINARY, we ran into "Not supported type" error with BlockSplitBloomFilter.hash() because String is not of type Binary.
This is an ugly solution and it only considers String type under BINARY.
Maybe there needs to be a function to transfer Iceberg type to Parquet type, like the reverse of ParquetConversions.converterFromParquet(colType, icebergType)?
Contributor
Author
|
Close in favor of #4831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split #2582 into several PRs.
This part adds support for reading parquet bloom filter to filter row groups.
I also wrote unit tests for ParquetBloomRowGroupFilter but it needs support for writing bloom filter. Will update unit tests once #2642 is merged.