Core: Apply encryption basics to writers and readers #2640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we combine this with the #2638 you published? They are not long and reader of this PR has to have context of that one anyway. |
Contributor
Author
|
The idea behind the split was to use the #2638 to highlight the challenge of encryption key passing, and to discuss the difference between native and stream encryption parameters. So it keeps only the minimal set of classes required to focus on these discussion topics. |
ggershinsky
changed the title
Contributor
Author
|
Replacing with an updated version #5544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of fresh data encryption keys is generated for each data file (in formats that support native encryption). The data keys are wrapped centrally (eg in the driver), potentially via KMS interaction, and stored in the manifest key_metadata entry for this data file. The data keys are delivered via NativeFileEncryptParams objects (see #2638) to the workers that perform data file writing/encryption.
@rdblue @jackye1995 @RussellSpitzer @flyrain @aokolnychyi