-
Notifications
You must be signed in to change notification settings - Fork 3k
Add support for Parquet BloomFilter #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
parquet/src/main/java/org/apache/iceberg/parquet/ColumnConfigParser.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.iceberg.parquet; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.function.BiConsumer; | ||
| import java.util.function.Function; | ||
| import org.apache.hadoop.conf.Configuration; | ||
|
|
||
| /** | ||
| * TODO: Once org.apache.parquet.hadoop.ColumnConfigParser is made public, should replace this class. | ||
| * Parses the specified key-values in the format of root.key#column.path from a {@link Configuration} object. | ||
| */ | ||
| class ColumnConfigParser { | ||
|
|
||
| private static class ConfigHelper<T> { | ||
| private final String prefix; | ||
| private final Function<String, T> function; | ||
| private final BiConsumer<String, T> consumer; | ||
|
|
||
| ConfigHelper(String prefix, Function<String, T> function, BiConsumer<String, T> consumer) { | ||
| this.prefix = prefix; | ||
| this.function = function; | ||
| this.consumer = consumer; | ||
| } | ||
|
|
||
| public void processKey(String key) { | ||
| if (key.startsWith(prefix)) { | ||
| String columnPath = key.substring(prefix.length()); | ||
| T value = function.apply(key); | ||
| consumer.accept(columnPath, value); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private final List<ConfigHelper<?>> helpers = new ArrayList<>(); | ||
|
|
||
| public <T> ColumnConfigParser withColumnConfig(String rootKey, Function<String, T> function, | ||
| BiConsumer<String, T> consumer) { | ||
| helpers.add(new ConfigHelper<T>(rootKey + '#', function, consumer)); | ||
| return this; | ||
| } | ||
|
|
||
| public void parseConfig(Configuration conf) { | ||
| for (Map.Entry<String, String> entry : conf) { | ||
| for (ConfigHelper<?> helper : helpers) { | ||
| // We retrieve the value from function instead of parsing from the string here to use the exact implementations | ||
| // in Configuration | ||
| helper.processKey(entry.getKey()); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public void parseConfig(Map<String, String> conf) { | ||
| for (Map.Entry<String, String> entry : conf.entrySet()) { | ||
| for (ConfigHelper<?> helper : helpers) { | ||
| // We retrieve the value from function instead of parsing from the string here to use the exact implementations | ||
| // in Configuration | ||
| helper.processKey(entry.getKey()); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iceberg doesn't use the same names that Parquet would, and it also doesn't use a
Configurationto store properties. We need to think about what would make sense for Iceberg here, and using#to delimit properties is probably too confusing.I think that the properties proposed in this PR for global defaults make sense, like
write.parquet.bloom-filter-enabled, although the NDV default is probably not useful given that we expect NDV to vary widely across fields. For the column-specific settings, I think we may want to follow the same pattern that is used by metrics collection. That embeds the column name in the property, likewrite.metadata.metrics.column.col1. This could bewrite.parquet.bloom-filter.col1.enabledorwrite.parquet.bloom-filter.col1.max-bytes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will try to change the configuration pattern when I have time.