Skip to content

Ensure the metadata isn't cleaned up in the case of unknown error #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rymurr wants to merge 1 commit into from
Closed

Ensure the metadata isn't cleaned up in the case of unknown error #2324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
String newMetadataLocation = writeNewMetadata(metadata, currentVersion() + 1);

boolean threw = true;
boolean delete = false;
try {
IcebergTable newTable = ImmutableIcebergTable.builder().metadataLocation(newMetadataLocation).build();
client.getContentsApi().setContents(key,
Expand All @@ -98,12 +99,14 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
newTable);
threw = false;
} catch (NessieConflictException ex) {
delete = true;
throw new CommitFailedException(ex, "Commit failed: Reference hash is out of date. " +
"Update the reference %s and try again", reference.getName());
} catch (NessieNotFoundException ex) {
delete = true;
throw new RuntimeException(String.format("Commit failed: Reference %s no longer exist", reference.getName()), ex);
} finally {
if (threw) {
if (threw && delete) {
io().deleteFile(newMetadataLocation);
}
}
Expand Down