[SPARK] Add in support to read timestamp without timezone from parquet files #2281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hive: Fix predicate pushdown for Date (apache#2254)
shardulm94
reviewed
Feb 28, 2021
| String fsscheme = "no_exist"; | ||
| try { | ||
| Configuration conf = SparkSession.active().sessionState().newHadoopConf(); | ||
| Configuration conf = new Configuration(activeSparkSession().sessionState().newHadoopConf()); |
Contributor
There was a problem hiding this comment.
Many changes in this file seems to be copied over from LinkedIn's fork which are not relevant to apache/iceberg. Can you remove these?
linkedin/iceberg#48 does not have these changes either. So not sure how those were copied over.
| tasks().stream() | ||
| .allMatch(combinedScanTask -> !combinedScanTask.isDataTask() && combinedScanTask.files() | ||
| .stream() | ||
| .allMatch(fileScanTask -> OrcRowFilterUtils.rowFilterFromTask(fileScanTask) == null)); |
Contributor
There was a problem hiding this comment.
This code was also not touched by linkedin/iceberg#48 and does not exist in apache/iceberg. Can you remove this?
These are several other changes in the files which are linkedin specific and were not touched by linkedin/iceberg#48
Contributor
Author
There was a problem hiding this comment.
@shardulm94 sorry yea, you're correct. I think I messed up while merging. I'll create new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting over code from @shardulm94 's PR
https://github.com/linkedin/iceberg/pull/48/files