add the descriptions for last-partition-id in docs #2224
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyanyy
reviewed
Feb 10, 2021
| | _required_ | | **`partition-spec`**| The table’s current partition spec, stored as only fields. Note that this is used by writers to partition data, but is not used when reading because reads use the specs stored in manifest files. (**Deprecated**: use `partition-specs` and `default-spec-id`instead ) | | ||
| | _optional_ | _required_ | **`partition-specs`**| A list of partition specs, stored as full partition spec objects. | | ||
| | _optional_ | _required_ | **`default-spec-id`**| ID of the “current” spec that writers should use by default. | | ||
| | _optional_ | _required_ | **`last-partition-id`**| An integer; the highest assigned partition field ID across all partition specs for the table. This is used to ensure partition fields are always assigned an unused ID when evolving specs. | |
Contributor
There was a problem hiding this comment.
Nit: might not need to mention integer since the JSON specifications section will include it, and also to maintain consistency with other rows mentioned in the table. Also "ensure partition fields are always assigned" -> "ensure new partition fields are always assigned to an"?
Contributor
There was a problem hiding this comment.
This matches the description for last-column-id, so I think it's okay.
rdblue
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2089