Hive: Avoid drop table related exceptions in MetaHook #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@pvary Can you please take a look? Thanks! |
pvary
reviewed
Feb 3, 2021
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Feb 3, 2021
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerLocalScan.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Feb 4, 2021
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Feb 4, 2021
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Feb 4, 2021
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Feb 4, 2021
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
Outdated
Show resolved
Hide resolved
pvary
approved these changes
Feb 4, 2021
Contributor
pvary
left a comment
pvary
left a comment
There was a problem hiding this comment.
Just a minor comment, but LGTM
Collaborator
Author
|
Thanks for your review @pvary! |
Contributor
|
Thanks for the fix @marton-bod |
aokolnychyi
pushed a commit
that referenced
this pull request
Mar 24, 2021
coolderli
pushed a commit
to coolderli/iceberg
that referenced
this pull request
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of scenarios where the Hive DDL command
DROP TABLEcan produce an error unnecessarily.FileNotFoundExceptionexception, because based on Hive2/Hive3 behaviour, the current assumption is that theHiveIcebergMetaHookhas to clean up the metadata files after the Hive drop table has completed. However, in Hive4, ifexternal.table.purge=TRUEis set, Hive will wipe the metadata folder as well.Extended some of the unit tests with explicit DROP TABLE commands in the end to test for the whole flow of CREATE, INSERT, DROP (which currently triggers problem # 1 on Hive4).