Rename last-assigned-partition-id to last-partition-id in table metadata #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| Integer lastAssignedPartitionId = JsonUtil.getIntOrNull(LAST_ASSIGNED_PARTITION_ID, node); | ||
| Integer lastAssignedPartitionId = JsonUtil.getIntOrNull(LAST_PARTITION_ID, node); |
Member
There was a problem hiding this comment.
Won't this break backwards compatibility?
Contributor
There was a problem hiding this comment.
This property was just added, so the rename is safe.
rdblue
reviewed
Feb 1, 2021
| this.nameToField = indexSpecByName(spec); | ||
| this.transformToField = indexSpecByTransform(spec); | ||
| this.lastAssignedPartitionId = base.lastAssignedPartitionId(); | ||
| this.lastAssignedPartitionId = base.lastPartitionId(); |
Contributor
There was a problem hiding this comment.
I don't think we need to rename the method, just the property in the metadata file.
Contributor
|
@jun-he, can you roll back the field and and method name changes in other classes? I think we only need to change the table metadata property, not the others. |
Collaborator
Author
|
@rdblue Thanks for the review and updated the PR accordingly. |
rdblue
approved these changes
Feb 1, 2021
Contributor
|
Thanks, @jun-he! Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2089