Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Jan 18, 2021

Contains Avro 1.10 :)

@github-actions github-actions bot added the build label Jan 18, 2021
@dongjoon-hyun
Copy link
Member

It seems that CI fails.

cc @sunchao

@Fokko Fokko mentioned this pull request Jan 18, 2021
@sunchao
Copy link
Member

sunchao commented Jan 18, 2021

Great to see this! I think you will need to specify version for calcite-core as well since it is excluded from hive-exec.

Note Hive 2.3.8 still uses Avro 1.8.2, although it should be compatible with Avro 1.10.

@Fokko
Copy link
Contributor Author

Fokko commented Jan 24, 2021

Thanks for pointing out @sunchao. I've added calcite-core as a dependency as well.

@dongjoon-hyun
Copy link
Member

Thank you for updating.

@rdblue
Copy link
Contributor

rdblue commented Jan 29, 2021

Why does this need to add Calcite dependencies?

@rdsr
Copy link
Contributor

rdsr commented Jan 31, 2021

Great to see this! I think you will need to specify version for calcite-core as well since it is excluded from hive-exec.

Note Hive 2.3.8 still uses Avro 1.8.2, although it should be compatible with Avro 1.10.

Seems like calcite-druid is only required during iceberg-mr testing [calcite-core is already include in test scope]. Instead of adding at compileOnly, I think we should only add calcite druid as a test dep under iceberg-mr only

@Fokko
Copy link
Contributor Author

Fokko commented Jan 31, 2021

@sunchao Can you shed some light on why calcite has been removed as a dependency from Hive? I haven't been involved in this discussion.

@rdsr Good catch, I've moved them to testCompile.

@sunchao
Copy link
Member

sunchao commented Jan 31, 2021

@Fokko it was removed as part of shading Guava- see HIVE-22126 and HIVE-23980.

@rdblue
Copy link
Contributor

rdblue commented Feb 1, 2021

Looks good. Thanks for catching the test issue, @rdsr!

Thanks for the update, @Fokko!

@rdblue rdblue merged commit 99df4cc into apache:master Feb 1, 2021
@Fokko Fokko deleted the fd-bump-hive branch February 1, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants