Fix the partition field id when appending a field to the V2 spec. #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jun-he
force-pushed
the
jun/fix-spec-field-id
branch
from
21cb153 to
d032221
Compare
yyanyy
approved these changes
Jan 13, 2021
Contributor
yyanyy
left a comment
yyanyy
left a comment
There was a problem hiding this comment.
Thank you for catching this!
Contributor
|
Good catch. We also still need to add a |
rdblue
approved these changes
Jan 13, 2021
Contributor
Is this just to ensure implementation correctness per spec? As it seems that from the current implementation getting this from |
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/iceberg
that referenced
this pull request
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field ID in the new spec should start with the largest last assigned partition id among all table specs.