-
Notifications
You must be signed in to change notification settings - Fork 3k
Nit - Align all comment indentation in TestStrictMetricsEvaluator #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nit - Align all comment indentation in TestStrictMetricsEvaluator #2058
Conversation
|
This came up while working on this issue: #1952 |
| .put(13, 1L) | ||
| .build(), | ||
| // nan value counts | ||
| // nan value counts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple maps being built above and below this that have a comment like this, but this comment doesn't align with the others.
jackye1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this!
|
I appreciate taking the time to keep the code clean, but I generally like to avoid commits that could cause conflicts simply to fix whitespace. It isn't unclear what the comment applies to, so I don't think that we should make this change. |
@yyanyy can you include this change in one of your commits? I think you added that comment line |
Yes, sorry I introduced this. I think currently I don't have any PR that touches this file though, and I think #2062 will likely modify this class; should we do it there instead so that we won't have conflict when either PR got merged? |
That makes sense to me. I can update the formatting in #2062 if we'd like. |
I pushed this change in #2062 as it already touches this file, so I'm closing this PR. |
I came across this small a nit of a formatting issue when working on another ticket.
This aligns the comments for all of the metrics instantiated when building the metrics of the TestDataFile.