Skip to content

Conversation

@jackye1995
Copy link
Contributor

As discussed in #1891 with @rdblue , shorten AWS config keys and change the following names:

  • gluecatalog.* to glue.*
  • s3fileio.* to s3.*
  • staging.dir to staging-dir
  • lock.impl to lock-impl
  • part-size to part-size-bytes

@danielcweeks are you okay with these changes?

@danielcweeks
Copy link
Contributor

I'm fine with updating the property names (especially adding the units), but I'm not clear on what convention is being used here. Using - as a delimiter seems pretty inconsistent with most projects I'm aware of (not that most tend to be internally consistent anyway).

@rdblue, If there is a specific convention, we should probably document so reviewers can point out inconsistencies going forward.

@danielcweeks danielcweeks merged commit 654fb9c into apache:master Jan 8, 2021
@rdblue
Copy link
Contributor

rdblue commented Jan 8, 2021

@danielcweeks, the convention is to use . as a delimiter for grouping and - between multiple words of the same term.

For example, in s3fileio.multipart.part.size the part is not a group or namespace for properties, it is one word of "part size". Similarly, bytes is part of the thing being configured and we would not expect to see other properties nested within size.

Other projects use a convention where all words are separated by . regardless, but I think it is easier to understand the context hierarchy if things described by more than one word are kept together.

Also, lock.impl vs lock-impl is a fuzzy case since lock is a group, but I think this should match the others, like io-impl.

XuQianJin-Stars pushed a commit to XuQianJin-Stars/iceberg that referenced this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants