Hive: TestHiveIcebergStorageHandler should not run all of the tests in every combination (#1924)#2030
Conversation
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerLocalScan.java
Show resolved
Hide resolved
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
Show resolved
Hide resolved
|
Looks like this is really effective at reducing build time! I'd still like to eliminate a lot of the tests that aren't adding much value. We should have tests for Hive reading formats and tests for Hive working with tables, but we don't need all the format tests run on all the tables, or all the table tests run across all formats and engines. |
|
JDK 8 tests run in 36 minutes! Great work, @pvary! |
|
Thanks for the review and the merge @rdblue! With this runtimes do you think we still need to separate out the integration tests? |
No, I think this is okay now. If we wanted to run all combinations, I'd say that is good for integration tests. But as long as we're careful about what we're testing and reducing the combinations if they don't provide much value we are good. |
As mentioned in #1924 this PR separates out the test cases needing a different combination of parameters