AWS: add client factory for assume role use case #2002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
commented
Dec 29, 2020
aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java
Show resolved
Hide resolved
| } catch (GlueException e) { | ||
| LOG.error("fail to create or delete Glue database", e); | ||
| Assert.fail("create and delete namespace should succeed"); | ||
| } |
There was a problem hiding this comment.
you should add a finally to retry to drop the namespace.
| Assert.assertEquals("Should see 403 error code", 403, e.statusCode()); | ||
| } | ||
|
|
||
| inputFile = s3FileIO.newInputFile("s3://" + AwsIntegTestUtil.testBucketName() + "/allowed/file"); |
Contributor
Author
There was a problem hiding this comment.
This file does not exist, I call inputFile.exsits() just to check it has access permission.
Contributor
|
Looks good to me, but I haven't been following much of the config discussion so I'll defer to @danielcweeks. |
Contributor
|
This looks good to me as well, but I think @giovannifumarola comment might still need to be addressed. Let me know and I'll push it through. |
danielcweeks
approved these changes
Jan 6, 2021
Contributor
danielcweeks
left a comment
danielcweeks
left a comment
There was a problem hiding this comment.
Thanks @jackye1995!
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/iceberg
that referenced
this pull request
Mar 22, 2021
* AWS: add client factory for assume role use case * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielcweeks as discussed in #1844 , separated PR for assume role client factory support.