Add additional partition spec update tests #1993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@rdblue @aokolnychyi can you take a look? Thanks. |
rdblue
reviewed
Dec 28, 2020
| TableMetadata updated = table.ops().current(); | ||
| Integer updatedVersion = TestTables.metadataVersion("test"); | ||
| Assert.assertEquals(current, updated); | ||
| Assert.assertEquals(++currentVersion, updatedVersion.intValue()); |
Contributor
There was a problem hiding this comment.
We don't use the return value of the ++ operator because it is not obvious which value is returned. Could you move these to separate lines?
Collaborator
Author
There was a problem hiding this comment.
Thanks for the comments and updated the PR accordingly.
aokolnychyi
approved these changes
Dec 29, 2020
Contributor
|
Thanks for adding these, @jun-he! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some of additional tests (from #922) for partition spec updates.