Add UpdatePartitionSpec operation for tables. #1942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jun-he, I've extracted the partition spec update operation from #922 and added it on top of #1919. Most of these changes are yours, except I swapped out the API. There are also some additional changes in #922 that I didn't add because I wanted to keep this small. It would be great to have some of those refactors done, like updating tests to use the new API, if you are interested in contributing those changes in separate PRs or rebasing #922. |
aokolnychyi
reviewed
Dec 16, 2020
| PartitionSpec spec = PartitionSpec.builderFor(schema).withSpecId(5) | ||
| .add(3, 1005, "x_partition", "bucket[4]") | ||
| .add(5, 1005, "z_partition", "bucket[8]") | ||
| .add(5, 1003, "z_partition", "bucket[8]") |
Contributor
There was a problem hiding this comment.
This was a typo before?
Contributor
Author
There was a problem hiding this comment.
The intent is to check whether the IDs are reassigned. The spec builder may reject duplicate IDs.
Contributor
Author
|
Thanks for reviewing, @aokolnychyi! |
Contributor
Author
|
Thanks for reviewing, @aokolnychyi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
UpdatePartitionSpectoTableandTransaction.These changes are extracted from #922 and @jun-he is the primary author.