Core: Support TableBuilder in CachingCatalog #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
commented
Dec 6, 2020
| .withPartitionSpec(spec) | ||
| .withLocation(location) | ||
| .withProperties(properties) | ||
| .create(); |
Contributor
Author
There was a problem hiding this comment.
We should consider moving these to be default implementations in the interface.
rymurr
approved these changes
Dec 7, 2020
aokolnychyi
reviewed
Dec 7, 2020
Contributor
|
This PR looks good to me but I think we should keep calling the |
Contributor
Author
|
Merged this. Thanks for reviewing, @rymurr and @aokolnychyi! |
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TableBuilder makes it easier to use catalogs from Spark, but the CachingCatalog doesn't currently support the builder so tests fail. This implements the builder for the CachingCatalog and uses it for the existing transaction methods. The existing tests should now exercise the builder.