Skip to content

AWS: support S3 strong consistency #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielcweeks merged 4 commits into from
Dec 3, 2020
Merged

AWS: support S3 strong consistency #1863

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5eac1c0
AWS: support S3 strong consistency
Dec 2, 2020
ad7aacf
remove call to HEAD
Dec 2, 2020
8dc3f5d
fix list wrong file with the same suffix
Dec 2, 2020
903f644
check file exists when getting length
Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions aws/src/main/java/org/apache/iceberg/aws/s3/BaseS3File.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import software.amazon.awssdk.services.s3.S3Client;
import software.amazon.awssdk.services.s3.model.HeadObjectRequest;
import software.amazon.awssdk.services.s3.model.HeadObjectResponse;
import software.amazon.awssdk.services.s3.model.ListObjectsV2Request;
import software.amazon.awssdk.services.s3.model.S3Exception;

abstract class BaseS3File {
Expand Down Expand Up @@ -77,6 +78,12 @@ public boolean exists() {

protected HeadObjectResponse getObjectMetadata() throws S3Exception {
if (metadata == null) {
// list object to force strong consistency
client().listObjectsV2(ListObjectsV2Request.builder()
.bucket(uri().bucket())
.prefix(uri().key())
Comment thread
danielcweeks marked this conversation as resolved.
.build());

HeadObjectRequest.Builder requestBuilder = HeadObjectRequest.builder()
.bucket(uri().bucket())
.key(uri().key());
Expand Down