Skip to content

Fix IntLongMath warnings #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shardulm94 merged 1 commit into from
Oct 11, 2020
Merged

Fix IntLongMath warnings #1581

shardulm94 merged 1 commit into from
Oct 11, 2020

Conversation

@kbendick
Copy link
Contributor

@kbendick kbendick commented Oct 11, 2020 •
edited
Loading

This patch fixes the following warning for IntLongMath

/iceberg/flink/src/main/java/org/apache/iceberg/flink/data/FlinkOrcWriters.java:135: warning: [IntLongMath] Expression of type int may overflow before being assigned to a long
      ((LongColumnVector) output).vector[rowId] = millis * 1000;
                                                         ^
    (see https://errorprone.info/bugpattern/IntLongMath)
  Did you mean '((LongColumnVector) output).vector[rowId] = millis * 1000L;'?

@kbendick kbendick changed the title Fix IntLongMath warnings and associated possible integer overflow Fix IntLongMath warnings Oct 11, 2020
@shardulm94 shardulm94 merged commit fdb068b into apache:master Oct 11, 2020
@shardulm94
Copy link
Contributor

shardulm94 commented Oct 11, 2020

Thanks @kbendick!

anuragmantri added a commit to anuragmantri/iceberg that referenced this pull request Jul 25, 2025
@anuragmantri @ajantha-bhat
Core: Refactor and use InternalData for partition stats (apache#12946) (
ed069a2 
apache#1581)

Co-authored-by: Ajantha Bhat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kbendick @shardulm94