ORC: Fix predicate pushdown for Not In and Not Equals #1536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORC uses SQL semantics for Search Arguments, so an expression like
col != 1will exclude rows where col is NULL along with rows wherecol = 1. In contrast, Iceberg's Expressions will keep rows with NULL values, so the equivalent ORC Search Argument for an Iceberg Expressioncol != xiscol IS NULL OR col != x.This PR fixes the issue of the ORC pushdown returning less rows than what Iceberg expects.
iceberg/data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java
Lines 741 to 742 in 78e80d2
The wider discussion of SQL compatibility for Iceberg expressions is discussed on the dev list.