Skip to content

Conversation

@mccheah
Copy link
Contributor

@mccheah mccheah commented Nov 27, 2018

Closes #13.

Allows an implementation to do something like this: #4, but by default we maintain the existing behavior of Util.getFS.

@rdblue
Copy link
Contributor

rdblue commented Nov 27, 2018

This looks good to me, but I wonder: should this be done along with the addition of a FileIO API? Maybe you should supply the FileIO API and use that in HadoopTableOperations to avoid the need for this. If we do it at the same time, that's a bit less API churn.

@mccheah
Copy link
Contributor Author

mccheah commented Nov 27, 2018

Should the FileIO API support file rename as well though? The FileSystem here is used for things other than fs.create, fs.delete, and fs.open. It also does stuff like exists.

@rdblue
Copy link
Contributor

rdblue commented Nov 27, 2018

I don't think that FileIO should handle other operations like rename. We could add exists to InputFile and OutputFile.

This is the only use of rename in the project. It is used to ensure that metadata commits are atomic when the underlying file system supports atomic rename. Since that's required for this class, then I think we should go ahead with this PR and add FileIO separately.

@rdblue rdblue merged commit 1cafa4b into apache:master Nov 27, 2018
mccheah added a commit to mccheah/incubator-iceberg that referenced this pull request Nov 28, 2018
fabio-rizzo-01 pushed a commit to fabio-rizzo-01/iceberg that referenced this pull request May 6, 2025
…e#15)

Bumps software.amazon.awssdk:bom from 2.31.31 to 2.31.35.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:bom
  dependency-version: 2.31.35
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants