-
Notifications
You must be signed in to change notification settings - Fork 3k
REST: Add spatial expressions to REST Catalog OpenAPI Spec #14856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
REST: Add spatial expressions to REST Catalog OpenAPI Spec #14856
Conversation
2bd1cc7 to
edeb340
Compare
singhpk234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kontinuation for the PR
since its the spec change can you please open a dev discuss thread for this ?
we would use this expression in the remote scan planning as a filter ? do you have any other use case in mind ?
|
The spec change is coupled with the design of spatial predicates and bounding box literals in #14101, so I'd like to start a dev thread once we reach consensus in that PR. We currently don't have use cases such as remote scan planning, this stems naturally when adding new predicate operators and literal types, the new predicates need to have a representation in the REST Catalog OpenAPI. |
|
I think we first need to finalize #14101 before we can discuss how this looks exactly at the REST layer (you can probably decouple the
|
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
This PR updates the REST Catalog OpenAPI specification to support spatial predicate operators and bounding box literals. This change aligns the REST spec with the core Iceberg expression updates proposed in #14101.
Changes:
st-intersectsandst-disjointto the allowedExpressionTypeenum.Here is an example of proposed JSON representation of spatial filter:
{ "type": "st-intersects", "term": "column-name", "value": { "x": { "min": 1.0, "max": 3.0 }, "y": { "min": 2.0, "max": 4.0 }, "z": { "min": 3.0, "max": 5.0 }, "m": { "min": 4.0, "max": 6.0 } } }