Exception on encryption key altering #14723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @huaxingao |
singhpk234
reviewed
Dec 1, 2025
| && !Objects.equals( | ||
| base.properties().get(TableProperties.ENCRYPTION_TABLE_KEY), | ||
| metadata.properties().get(TableProperties.ENCRYPTION_TABLE_KEY))) { | ||
| throw new RuntimeException("Cannot modify key in encrypted table"); |
Contributor
There was a problem hiding this comment.
should this be IllegalState / IllegalArgs exception ?
Comment on lines
+329
to
+330
| base.properties().get(TableProperties.ENCRYPTION_TABLE_KEY), | ||
| metadata.properties().get(TableProperties.ENCRYPTION_TABLE_KEY))) { |
Contributor
There was a problem hiding this comment.
IIUC, this now means table REPLACEs must have the same key property as before (+ you can't add a key when you replace).
Makes sense to me. WDYT about adding a test case to document that?
Contributor
Author
There was a problem hiding this comment.
sure, will appreciated if you'd add it in 14659 or 13225.
Contributor
There was a problem hiding this comment.
huaxingao
approved these changes
Dec 4, 2025
Contributor
|
Thanks @ggershinsky for the PR! Thanks @singhpk234 @smaheshwar-pltr for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.