Core: Classify RowDelta with data files only as APPEND #14581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When RowDelta only adds data files without adding delete files or deleting data files, it should be classified as an APPEND operation instead of OVERWRITE. This is similiar to the existing logic in OverwriteFiles: https://github.com/apache/iceberg/blame/main/core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java#L56
pvary
reviewed
Nov 13, 2025
singhpk234
reviewed
Nov 17, 2025
|
|
||
| @TestTemplate | ||
| public void addOnlyDataFilesProducesAppendOperation() { | ||
| SnapshotUpdate<?> rowDelta = table.newRowDelta().addRows(FILE_A).addRows(FILE_B); |
Contributor
There was a problem hiding this comment.
how about adding a case simulating this as well : https://github.com/apache/iceberg/pull/14581/files#r2524111562
Contributor
There was a problem hiding this comment.
+1 on adding this test case
stevenzwu
approved these changes
Nov 17, 2025
singhpk234
approved these changes
Nov 18, 2025
Contributor
|
Merged to main. |
Contributor
Author
|
Thank you everyone for the reviews! And thanks for merging @pvary. |
bezdomniy
pushed a commit
to bezdomniy/iceberg
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RowDelta only adds data files without adding delete files or deleting data files, the snapshot should be classified as an APPEND operation instead of OVERWRITE. The resulting operation is quite important because readers which read only append snapshots won't process overwrite snapshots.
The patch here is similar to the existing logic in OverwriteFiles: https://github.com/apache/iceberg/blame/main/core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java#L56
Merging this would avoid patches like #14559, where separate code paths are required for the overwrite and the append path.