Add Support for Kafka Connect commit validation #14506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@kumarpritam863 you might be interested in this PR also |
singhpk234
reviewed
Nov 5, 2025
Comment on lines
+327
to
+332
| private Snapshot latestSnapshot(TableMetadata metadata, String branch) { | ||
| if (branch == null) { | ||
| return metadata.currentSnapshot(); | ||
| } | ||
| return metadata.snapshot(metadata.ref(branch).snapshotId()); | ||
| } |
Contributor
There was a problem hiding this comment.
probably we can move this to SnapshotUtil
|
|
||
| private Map<Integer, Long> lastCommittedOffsetsForTable(TableMetadata metadata, String branch) { | ||
| Snapshot snapshot = latestSnapshot(metadata, branch); | ||
| while (snapshot != null) { |
Contributor
There was a problem hiding this comment.
[optional] we can get an iterable of ancestors from the SnapshotUtils
Comment on lines
+296
to
+306
| Map<Integer, Long> lastCommittedOffsets = lastCommittedOffsetsForTable(base, branch); | ||
|
|
||
| if (expectedOffsets == null || expectedOffsets.isEmpty()) { | ||
| return; // there are no stored offsets, so assume we're starting with new offsets | ||
| } | ||
|
|
||
| if (!expectedOffsets.equals(lastCommittedOffsets)) { | ||
| throw new CommitFailedException( | ||
| "Latest offsets do not match expected offsets for this commit."); | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
[doubt] wouldn't this be lastCommittedOffset ?
if expectedOffset is null and lastCommittedOffset is non empty then we should fail ?
Suggested change
| Map<Integer, Long> lastCommittedOffsets = lastCommittedOffsetsForTable(base, branch); | |
| if (expectedOffsets == null || expectedOffsets.isEmpty()) { | |
| return; // there are no stored offsets, so assume we're starting with new offsets | |
| } | |
| if (!expectedOffsets.equals(lastCommittedOffsets)) { | |
| throw new CommitFailedException( | |
| "Latest offsets do not match expected offsets for this commit."); | |
| } | |
| }; | |
| Map<Integer, Long> lastCommittedOffsets = lastCommittedOffsetsForTable(base, branch); | |
| if (lastCommittedOffsets == null || lastCommittedOffsets.isEmpty()) { | |
| return; // there are no stored offsets, so assume we're starting with new offsets | |
| } | |
| // handle case for expectedOffsets being null too | |
| if (!lastCommittedOffsets.equals(expectedOffsets)) { | |
| throw new CommitFailedException( | |
| "Committed offsets do not match expected offsets for this commit."); | |
| } | |
| }; |
Contributor
Author
There was a problem hiding this comment.
I debated this, but I'm not sure what the expected behavior should be in that case. It seems likely that we want to error in that case as well, but the scenario around it is less clear to me.
Contributor
Author
|
Closed in favor of #14510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #14503 which adds commit validation.
The changes in this PR ensure that the expected commit offsets are not updated when table is refreshed during the commit process. This prevents a concurrent KC committer from updating the offsets resulting in duplicate processing of events.