Core: Fix view version ID deduplication with schema ID assignment #14434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix the test would fail with ``` Cannot set current version to unknown version: 3 java.lang.IllegalArgumentException: Cannot set current version to unknown version: 3 at org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:190) at org.apache.iceberg.view.ViewMetadata$Builder.setCurrentVersionId(ViewMetadata.java:241) at org.apache.iceberg.view.TestViewMetadata.deduplicatingViewVersionByIdAndAssigningSchemaId(TestViewMetadata.java:991) at java.base/java.lang.reflect.Method.invoke(Method.java:568) ``` because the the `ViewVersion` was assigned a new ID and later when we tried to re-assign the schema ID, we used the wrong `ViewVersion` instance (the one where the version ID was not re-assigned).
amogh-jahagirdar
approved these changes
Oct 28, 2025
singhpk234
approved these changes
Oct 28, 2025
huaxingao
approved these changes
Oct 28, 2025
Contributor
|
Thanks @nastra for the PR! Thanks @amogh-jahagirdar @singhpk234 for the review! |
This was referenced Jan 8, 2026
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
…ache#14434) Without this fix the test would fail with ``` Cannot set current version to unknown version: 3 java.lang.IllegalArgumentException: Cannot set current version to unknown version: 3 at org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:190) at org.apache.iceberg.view.ViewMetadata$Builder.setCurrentVersionId(ViewMetadata.java:241) at org.apache.iceberg.view.TestViewMetadata.deduplicatingViewVersionByIdAndAssigningSchemaId(TestViewMetadata.java:991) at java.base/java.lang.reflect.Method.invoke(Method.java:568) ``` because the the `ViewVersion` was assigned a new ID and later when we tried to re-assign the schema ID, we used the wrong `ViewVersion` instance (the one where the version ID was not re-assigned).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix the test would fail with
because the the
ViewVersionwas assigned a new ID and later when we tried to re-assign the schema ID, we used the wrongViewVersioninstance (the one where the version ID was not re-assigned).