site: use virtualenv and add make lint #14428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
reviewed
Oct 28, 2025
| deploy: # Clean, build, and deploy the Iceberg docs site. | ||
| dev/deploy.sh $(remote_name) | ||
|
|
||
| .PHONY: lint |
manuzhang
reviewed
Oct 28, 2025
| set -e | ||
|
|
||
| export REMOTE="iceberg_docs" | ||
| export VENV_DIR=".venv" |
Member
There was a problem hiding this comment.
do we ever clean up this dir?
Contributor
Author
There was a problem hiding this comment.
i dont think so. i could add it to the clean command, but i think its also fine to leave it alone
Member
|
@kevinjqliu Thanks for the follow-up PR. Can you also help to add |
manuzhang
reviewed
Nov 2, 2025
site/README.md
Outdated
| ``` | ||
|
|
||
| It will also scan all markdown files and fail the build on any style issues. To fix style issues, run the `lint` script with fix mode. | ||
| It will also scan all markdown files and fail the build on any style issues. To fix style issues, run the `lint-fix` make command. |
Member
There was a problem hiding this comment.
I don't think we need to mention lint-fix here, since it will be immediately covered in the following section.
manuzhang
approved these changes
Nov 3, 2025
Member
|
@kevinjqliu Sorry, although my approval is marked green by GitHub, I'm not a committer and that should not count as one. |
Contributor
Author
|
oops, good catch @manuzhang. let me ping someone else |
Contributor
|
Late LGTM |
Contributor
Author
|
Thank you @huaxingao. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #13977
This PR adds
make lintandmake lint-fixtosite/'s Makefile.This PR also creates a python virtual env to install the required libraries and runs docs-ci with ubuntu and macos
Tested