-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Doc: Remove Spark 3 specific wordings in docs #14357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
eb67961
b0d711a
606d6f1
5825e88
5033945
6efed89
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -274,7 +274,7 @@ This configuration creates a path-based catalog named `local` for tables under ` | |||||||||
| === "CLI" | ||||||||||
|
|
||||||||||
| ```sh | ||||||||||
| spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{ icebergVersion }}\ | ||||||||||
| spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-{{ sparkVersionMajor }}:{{ icebergVersion }}\ | ||||||||||
| --conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \ | ||||||||||
| --conf spark.sql.catalog.spark_catalog=org.apache.iceberg.spark.SparkSessionCatalog \ | ||||||||||
| --conf spark.sql.catalog.spark_catalog.type=hive \ | ||||||||||
|
|
@@ -287,7 +287,7 @@ This configuration creates a path-based catalog named `local` for tables under ` | |||||||||
| === "spark-defaults.conf" | ||||||||||
|
|
||||||||||
| ```sh | ||||||||||
| spark.jars.packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{ icebergVersion }} | ||||||||||
| spark.jars.packages org.apache.iceberg:iceberg-spark-runtime-{{ sparkVersionMajor }}:{{ icebergVersion }} | ||||||||||
| spark.sql.extensions org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions | ||||||||||
| spark.sql.catalog.spark_catalog org.apache.iceberg.spark.SparkSessionCatalog | ||||||||||
| spark.sql.catalog.spark_catalog.type hive | ||||||||||
|
|
@@ -309,27 +309,27 @@ If you already have a Spark environment, you can add Iceberg, using the `--packa | |||||||||
| === "SparkSQL" | ||||||||||
|
|
||||||||||
| ```sh | ||||||||||
| spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{ icebergVersion }} | ||||||||||
| spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-{{ sparkVersionMajor }}:{{ icebergVersion }} | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| === "Spark-Shell" | ||||||||||
|
|
||||||||||
| ```sh | ||||||||||
| spark-shell --packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{ icebergVersion }} | ||||||||||
| spark-shell --packages org.apache.iceberg:iceberg-spark-runtime-{{ sparkVersionMajor }}:{{ icebergVersion }} | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| === "PySpark" | ||||||||||
|
|
||||||||||
| ```sh | ||||||||||
| pyspark --packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{ icebergVersion }} | ||||||||||
| pyspark --packages org.apache.iceberg:iceberg-spark-runtime-{{ sparkVersionMajor }}:{{ icebergVersion }} | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| !!! note | ||||||||||
| If you want to include Iceberg in your Spark installation, add the Iceberg Spark runtime to Spark's `jars` folder. | ||||||||||
| You can download the runtime by visiting to the [Releases](releases.md) page. | ||||||||||
|
|
||||||||||
| <!-- markdown-link-check-disable-next-line --> | ||||||||||
| [spark-runtime-jar]: https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.5_2.12/{{ icebergVersion }}/iceberg-spark-runtime-3.5_2.12-{{ icebergVersion }}.jar | ||||||||||
| [spark-runtime-jar]: https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-{{ sparkVersionMajor }}/{{ icebergVersion }}/iceberg-spark-runtime-{{ sparkVersionMajor }}-{{ icebergVersion }}.jar | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: this isnt rendered
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agreed, we dont need to expose the jar directly
Comment on lines
330
to
+332
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
lets remove this then |
||||||||||
|
|
||||||||||
| #### Learn More | ||||||||||
|
|
||||||||||
|
|
||||||||||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please share a snapshot of this page after the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.