API: Detect whether required fields nested within optionals can produce nulls #14270
+340
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
nested-fields-with-nulls
branch
from
cb947c6 to
df5466b
Compare
Contributor
Author
|
@pvary @huaxingao @stevenzwu could you review this one please since you reviewed #13804 already? |
…ce nulls This partially reverts some changes around the `Accessor` API that were introduced by apache#13804 and uses a Schema visitor to detect whether any of the parent fields of a nested required field are optional. This info is then used when IS_NULL / NOT_NULL is evaluated
nastra
force-pushed
the
nested-fields-with-nulls
branch
from
df5466b to
ccb4cbd
Compare
nastra
commented
Oct 7, 2025
| assertThat(pred.term().type()).isEqualTo(Types.fromPrimitiveString(typeName)); | ||
| } | ||
|
|
||
| private static Stream<Arguments> nullCasesWithNestedStructs() { |
Contributor
Author
There was a problem hiding this comment.
this code has been moved from TestBoundReference and slightly adjusted for better readability
nastra
commented
Oct 7, 2025
| } | ||
|
|
||
| @Test | ||
| public void testIsNullInNestedStruct() { |
Contributor
Author
There was a problem hiding this comment.
added some additional evaluator tests that reproduce the original problem described in #13804
pvary
reviewed
Oct 8, 2025
| private Expression bindUnaryOperation(BoundTerm<T> boundTerm) { | ||
| private Expression bindUnaryOperation(StructType struct, BoundTerm<T> boundTerm) { | ||
| boolean allFieldsAreRequired = | ||
| TypeUtil.findParents(struct.asSchema(), boundTerm.ref().fieldId()).stream() |
Contributor
There was a problem hiding this comment.
How often do we evaluate these expressions? For every manifest entry?
For a wide schema, what is the additional cost of calculating the parents every time?
Contributor
Author
There was a problem hiding this comment.
we would evaluate these whenever we have an unbound predicate that we want to bind. I've updated this so that it's only evaluated when having a IS_NULL or NOT_NULL and when !boundTerm.producesNull() evaluates to true
nastra
force-pushed
the
nested-fields-with-nulls
branch
from
783db2f to
fdba428
Compare
huaxingao
reviewed
Oct 8, 2025
stevenzwu
approved these changes
Oct 9, 2025
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
nested-fields-with-nulls
branch
from
fdba428 to
ea2ce47
Compare
nastra
force-pushed
the
nested-fields-with-nulls
branch
from
ea2ce47 to
c588bb1
Compare
Contributor
|
Thanks @nastra for the PR! Thanks @stevenzwu @pvary for the review! |
huaxingao
pushed a commit
to huaxingao/iceberg
that referenced
this pull request
Nov 6, 2025
…ce nulls (apache#14270) * API: Detect whether required fields nested within optionals can produce nulls This partially reverts some changes around the `Accessor` API that were introduced by apache#13804 and uses a Schema visitor to detect whether any of the parent fields of a nested required field are optional. This info is then used when IS_NULL / NOT_NULL is evaluated * only check parent fields on IS_NULL/NOT_NULL (cherry picked from commit a473b1c)
huaxingao
added a commit
that referenced
this pull request
Nov 6, 2025
…ce nulls (#14270) (#14512) * API: Detect whether required fields nested within optionals can produce nulls This partially reverts some changes around the `Accessor` API that were introduced by #13804 and uses a Schema visitor to detect whether any of the parent fields of a nested required field are optional. This info is then used when IS_NULL / NOT_NULL is evaluated * only check parent fields on IS_NULL/NOT_NULL (cherry picked from commit a473b1c) Co-authored-by: Eduard Tudenhoefner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts some changes around the
AccessorAPI that were introduced by #13804 and uses a Schema visitor to detect whether any of the parent fields of a nested required field are optional. This info is then used when IS_NULL / NOT_NULL is evaluated