REST: Add missing "added-rows" field to snapshot metadata #14177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenzwu
approved these changes
Sep 24, 2025
huaxingao
approved these changes
Sep 24, 2025
Fokko
approved these changes
Sep 24, 2025
singhpk234
approved these changes
Sep 24, 2025
stevenzwu
changed the title
stevenzwu
changed the title
Contributor
|
Will leave this open for another day. I don't think this REST spec change requires a separate voting. I think the previous voting on the table spec change should also cover this one. |
kevinjqliu
approved these changes
Sep 24, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks!
Here's the previous devlist discussion / vote thread on bringing back added-rows
https://lists.apache.org/thread/5gff76hvqy7r1lksrt9ld9h3pdp03nb5
amogh-jahagirdar
approved these changes
Sep 24, 2025
Contributor
|
thanks @c-thiel for the fix and everyone for the review |
gabeiglio
pushed a commit
to gabeiglio/iceberg
that referenced
this pull request
Oct 1, 2025
adawrapub
pushed a commit
to adawrapub/iceberg
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #14048, we need to bring back "added-rows" to the IRC as well.