Core: Fix Scan Plan API resource paths #14120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
force-pushed
the
fix/routes-scan-plan
branch
from
d8ad844 to
30dd83a
Compare
nastra
reviewed
Sep 19, 2025
nastra
reviewed
Sep 19, 2025
nastra
approved these changes
Sep 19, 2025
amogh-jahagirdar
approved these changes
Sep 19, 2025
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Thanks for fixing this @singhpk234 !
RussellSpitzer
approved these changes
Sep 19, 2025
Member
|
@amogh-jahagirdar Isn't duck db using these routes? |
stevenzwu
approved these changes
Sep 19, 2025
ebyhr
approved these changes
Sep 19, 2025
Contributor
Author
My understanding is duck db is entirely C++, they don't use Java SDK like impala IMHO. |
Contributor
|
Contributor
|
I'll go ahead and merge, thanks @singhpk234 and thanks everyone for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
Fix incorrect scan plan API routes, as scan plan APIs are table scoped its required to contain namespace to correctly identify the table, which is inline with the spec.
Orthogonal since post 1.10 we released Req / Response model for the Scan Plan the servers would be able to use this to be ready from the server side using this constant can cause some issue, may be its fine if we just update this public constant in subsequent release since this has been there since 1.8.0 via