Skip to content

Conversation

@smaheshwar-pltr
Copy link
Contributor

I see #11389 (comment) - but was curious if folks would be open to making this public so that REST catalogs implemented in Java can use S3FileIOProperties.SESSION_TOKEN_EXPIRES_AT_MS instead of hard-coding the string constant when returning token expirations.

@github-actions github-actions bot added the AWS label Sep 1, 2025
* vended credentials.
*/
static final String SESSION_TOKEN_EXPIRES_AT_MS = "s3.session-token-expires-at-ms";
public static final String SESSION_TOKEN_EXPIRES_AT_MS = "s3.session-token-expires-at-ms";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in PR description, #11389 (comment) is understandable so happy to close this one out if folks feel strongly. (I think it would be nice to let Java catalogs use this though)

@smaheshwar-pltr smaheshwar-pltr changed the title Make S3FileIO token expiration property public AWS: Make S3FileIO token expiration property public Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 2, 2025
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant